perf(build): use zstd instead of gzip for weblog image compression#7011
Conversation
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 0e05d6b | Docs | Datadog PR Page | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0dc377df6e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if [ -f "$BINARIES_FILENAME" ]; then | ||
| echo "Loading image from $BINARIES_FILENAME" | ||
| docker load --input $BINARIES_FILENAME | ||
| zstd -d -c "$BINARIES_FILENAME" | docker load |
There was a problem hiding this comment.
In environments that have Docker but not the zstd CLI, the downloaded weblog artifact can no longer be loaded because this path now shells out to zstd before docker load; the run-end-to-end.yml/debug-harness.yml test jobs download binaries/ and call ./build.sh without installing that tool. Docker's own load command documents that it can read tar archives compressed with gzip, bzip2, xz, or zstd from --input/STDIN, so using docker load --input "$BINARIES_FILENAME" here would preserve the new artifact format without adding a new runtime dependency to every artifact consumer.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
That's fine, it's only used on GHA.
Switches from gzip to zstd for saving/loading weblog image artifacts, yielding faster compression with better ratios. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
rochdev
force-pushed
the
rochdev/perf-gzip-to-zst
branch
from
0dc377d to
0e05d6b
Compare
2 participants
Summary
gzipwithzstdfor saving and loading weblog image artifacts inbuild.sh.tar.gzto.tar.zst$BINARIES_FILENAMEvariable referencesDependencies
None — this PR is independent and can be merged in any order.
Test plan
--save-to-binariesand verify the.tar.zstartifact is created🤖 Generated with Claude Code